Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Membership] Addressing recovery from contention on membership writes #9376

Merged
merged 6 commits into from
Mar 24, 2025

Conversation

rkargMsft
Copy link
Contributor

@rkargMsft rkargMsft commented Mar 9, 2025

This alleviates overloading clustering storage when it is performing slower than normal request rates.

Microsoft Reviewers: Open in CodeFlow

This appears to be the only two places with writes that would have retries when encountering slow membership backends that doesn't have exponential backoffs.

@rkargMsft rkargMsft changed the title Backing off Periodic Membership refresh Addressing recovery from contention on membership writes Mar 11, 2025
@rkargMsft rkargMsft marked this pull request as ready for review March 12, 2025 21:04
@rkargMsft rkargMsft changed the title Addressing recovery from contention on membership writes [Membership] Addressing recovery from contention on membership writes Mar 13, 2025
Copy link
Contributor

@dmorganMsft dmorganMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this in the next release! This helped when using Cassandra clustering with a multi-dc deployment where the LWTs are particularly slow

rkargMsft and others added 6 commits March 20, 2025 19:20
This alleviates overloading clustering storage when it is performing slower than normal request rates.
This helps avoid contention and increases the chance that one silo will perform the operation.
@ReubenBond
Copy link
Member

@rkargMsft if my changes look good to you, I'm ready to merge.

@rkargMsft
Copy link
Contributor Author

@ReubenBond LGTM

@ReubenBond ReubenBond merged commit c723211 into dotnet:main Mar 24, 2025
24 of 25 checks passed
@rkargMsft rkargMsft deleted the patch-1 branch March 24, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants