Avoid creation of temporary strings where possible #11380
Conversation
| string extension = Path.GetExtension(path); | ||
|
|
||
| if (string.Equals(extension, ".dll", StringComparison.OrdinalIgnoreCase)) | ||
| if (!string.IsNullOrEmpty(path) && path.EndsWith(".dll", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
That means "does this path have an extension", not "does this path have the specified extension", sadly.
| string extension = Path.GetExtension(path); | ||
|
|
||
| if (string.Equals(extension, ".dll", StringComparison.OrdinalIgnoreCase)) | ||
| if (!string.IsNullOrEmpty(path) && path.EndsWith(".dll", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
That means "does this path have an extension", not "does this path have the specified extension", sadly.
| @@ -299,7 +299,11 @@ public bool IsTraversal | |||
| { | |||
| if (!_isTraversalProject.HasValue) | |||
| { | |||
| if (String.Equals(Path.GetFileName(ProjectFullPath), "dirs.proj", StringComparison.OrdinalIgnoreCase)) | |||
| #if NET471_OR_GREATER | |||
| if (MemoryExtensions.Equals(Microsoft.IO.Path.GetFileName(ProjectFullPath.AsSpan()), "dirs.proj".AsSpan(), StringComparison.OrdinalIgnoreCase)) | |||
There was a problem hiding this comment.
Are you doing this explicitly here to be conservative/localized (totally legit!) or because there's a reason not to shift to Microsoft.IO.Redist elsewhere in this file?
There was a problem hiding this comment.
There can be subtle differences in behavior between NetFX System.IO.Path and Microsoft.IO.Path, so this was meant to be a surgical update to minimize churn. In other repositories, we've seen measurable improvement fully switching over to Microsoft.IO, so this should be considered as well.
One thing to note: Since Microsoft.IO is a snapshot of improvements backported for NetFX, we want to use System.IO in .NET 5+. That way we'll continue to benefit from future improvements.
Fixes #
Context
Changes Made
Testing
Notes