Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semver2 #11360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use semver2 #11360

wants to merge 1 commit into from

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jan 29, 2025

The roslyn issue

@mmitche mmitche requested a review from rainersigwald January 29, 2025 23:59
@mmitche mmitche requested a review from a team as a code owner January 29, 2025 23:59
@mmitche
Copy link
Member Author

mmitche commented Jan 30, 2025

Not quite sure why stringtools was specifically enabling this...any idea @rainersigwald. Nothing interesting in the history. It starts this way.

JanKrivanek
JanKrivanek approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@JanKrivanek
Copy link
Member

Context: https://github.com/dotnet/arcade/blob/915b22bcc37de5b18bc2a6328629c4e0ba15fb5b/Documentation/ArcadeSdk.md?plain=1#L947

rainersigwald
rainersigwald requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any evidence that the Roslyn issue is resolved so I think this would be a customer-breaking change. What's your motivation here?

@mmitche
Copy link
Member Author

mmitche commented Jan 30, 2025

Motivation is mainly aligning msbuild with the rest of the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald requested changes

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @JanKrivanek @rainersigwald