Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #10121: Add possibility to control whether to fix the paths of TaskItem using metadata #10126

Commits on May 11, 2024

  1. Bug dotnet#10121: Add possibility to control whether to fix the paths…

    … of TaskItem using metadata
    
    To be able to have TaskItems that you don't want normalised, or you want then normalised to
    another OS, e.g. when using dotnet publish to containers to another OS than you are building on,
    I suggest using "magic" metadata names to be able to tell in an MSBuild file that you want a property
    on your build item of type TaskItem to either:
    
    * _not_ have the paths normalised at all, by setting the FixFilePath metadata to "false" (defaults to true, of course), or
    * normalise the paths to a different platform by specifying the TargetOs metadata with one of the following values:
      - windows
      - unix
      - current (is also used if the property is specified, but an empty or invalid value is supplied)
    erikbra committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0ad62b3 View commit details
    Browse the repository at this point in the history
  2. Separated tests out in separate file. Wrote some tests on actual proj…

    …ect, and found out the problem is deeper...
    
    there are _MANY_ implementations of ITaskItem, and usages of FixFilePaths
    erikbra committed May 11, 2024
    Configuration menu
    Copy the full SHA
    cf14704 View commit details
    Browse the repository at this point in the history