Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Convert Terminal Logger to a ForwardingLogger #9806

Open
baronfel opened this issue Feb 29, 2024 · 1 comment
Open

[Feature Request]: Convert Terminal Logger to a ForwardingLogger #9806

baronfel opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Feature Request Priority:2 Work that is important, but not critical for the release triaged

Comments

@baronfel
Copy link
Member

Summary

TerminalLogger needs to have a forwarded logger component and a central logging component so that it can intelligently forward events from multiple build nodes to the central logger that writes to the console stream.

Background and Motivation

In #9805 I tried to use TaskParameterEventArgs to read values from Targets over the course of a build. This works for a single-process build, but for multi-process builds the current configuration only forwards certain verbosities of events, which means the feature will not work.

Proposed Feature

TerminalLogger should provide a custom forwarding logger implementation that can forward relevant events back to the central node for performant updates.

Alternative Designs

No response

@baronfel baronfel added Feature Request needs-triage Have yet to determine what bucket this goes in. labels Feb 29, 2024
@AR-May AR-May added triaged Priority:2 Work that is important, but not critical for the release and removed needs-triage Have yet to determine what bucket this goes in. labels Mar 5, 2024
@baronfel baronfel added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Mar 14, 2024
@baronfel
Copy link
Member Author

baronfel commented Sep 7, 2024

Note that when we do this, we will need to update the SDK's dotnet run implementation. It currently creates an instance of TL via reflection for use during API-based builds, and once TL is a forwarding logger we'll break that usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Feature Request Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Development

No branches or pull requests

2 participants