Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Terminal Logger primary outputs should optionally use absolute paths #9740

Open
baronfel opened this issue Feb 14, 2024 · 1 comment
Assignees
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Feature Request triaged

Comments

@baronfel
Copy link
Member

baronfel commented Feb 14, 2024

Summary

In dotnet/sdk#38552 @tmds requested that the primary outputs of built projects be able to emit the absolute path instead of relative paths. While we don't think this should be the default behavior, some kind of knob here does make sense for their use case.

Background and Motivation

We chose relative paths for the output (with clickable/right-click-able directory urls) for readability and usability based on customer feedback from the first Terminal Logger releases. However some user workflows benefit from copying the direct file.

Proposed Feature

We should enable this either by emitting the absolute path visually, or by making the generated file://-scheme URIs (for terminals that support clickable links) emit absolute paths. This should be toggled via some option, it should not be the default.

Alternative Designs

No response

@baronfel baronfel added Feature Request needs-triage Have yet to determine what bucket this goes in. Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. labels Feb 14, 2024
@f-alizada f-alizada added triaged and removed needs-triage Have yet to determine what bucket this goes in. labels Feb 20, 2024
@baronfel
Copy link
Member Author

baronfel commented Mar 14, 2024

This was also requested by @KalleOlaviNiemitalo in #9800 (comment).

We'll implement this by checking for the the GenerateFullPaths property, which other tools in the toolchain already set and make use of. TL breaks pretty badly when GenerateFullPaths is false - we need to figure out why that is.

We need to tackle two enablers first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Feature Request triaged
Projects
None yet
Development

No branches or pull requests

3 participants