Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend dataframe orderby method to allow defining preferred position for null values #7118

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Extend dataframe orderby method to allow defining preferred position for null values #7118

merged 1 commit into from
Jun 6, 2024

Conversation

asmirnov82
Copy link
Contributor

Fixes #7102

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.49%. Comparing base (07eb681) to head (7585c2a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7118   +/-   ##
=======================================
  Coverage   68.48%   68.49%           
=======================================
  Files        1262     1262           
  Lines      255113   255145   +32     
  Branches    26364    26368    +4     
=======================================
+ Hits       174722   174750   +28     
  Misses      73682    73682           
- Partials     6709     6713    +4     
Flag Coverage Δ
Debug 68.49% <94.28%> (+<0.01%) ⬆️
production 62.87% <91.48%> (-0.01%) ⬇️
test 88.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.cs 85.27% <100.00%> (-0.15%) ⬇️
src/Microsoft.Data.Analysis/DataFrameColumn.cs 65.67% <100.00%> (+2.50%) ⬆️
...Analysis/DataFrameColumns/StringDataFrameColumn.cs 69.62% <100.00%> (-1.56%) ⬇️
...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs 87.80% <100.00%> (+0.46%) ⬆️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.90% <100.00%> (+<0.01%) ⬆️
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 63.17% <0.00%> (ø)
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 44.44% <0.00%> (-0.16%) ⬇️
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 71.91% <66.66%> (-0.54%) ⬇️

... and 4 files with indirect coverage changes

@asmirnov82
Copy link
Contributor Author

cc @JakeRadMSFT

@asmirnov82 asmirnov82 changed the title Extend dataframe orderby method to allow define null values preferred position Extend dataframe orderby method to allow define preferred position for null values Apr 16, 2024
@asmirnov82 asmirnov82 changed the title Extend dataframe orderby method to allow define preferred position for null values Extend dataframe orderby method to allow defining preferred position for null values Apr 16, 2024
@JakeRadMSFT JakeRadMSFT merged commit b67107b into dotnet:main Jun 6, 2024
25 checks passed
@asmirnov82 asmirnov82 deleted the 7102_extend_dataframe_orderby_method branch June 6, 2024 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.OrderBy methods incorrect behavior with null values
2 participants