-
Notifications
You must be signed in to change notification settings - Fork 600
Fix access violation issue in libgpiod v1 driver #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
e2535bb
be654e6
1f4b066
cd8331f
c96a27d
3fa74d6
7c4dcd2
32f5d4e
3bf0188
c06f7e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,12 @@ | |
<Left>lib/netstandard2.0/System.Device.Gpio.dll</Left> | ||
<Right>lib/net6.0-windows10.0.17763/System.Device.Gpio.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0002</DiagnosticId> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't expect this to show up as we should have the finalizer in both places. Can you please check why this is needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have no clue, but looks like a bug of the tool to me. We have added a finalizer, so why should there be a warning that it's now missing? I can't see why this would be a breaking change, anyway. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I verified the generated IL. The finalize method is also present in the netstandard2.0 assembly. |
||
<Target>M:System.Device.Gpio.GpioDriver.Finalize</Target> | ||
<Left>lib/netstandard2.0/System.Device.Gpio.dll</Left> | ||
<Right>lib/net6.0-windows10.0.17763/System.Device.Gpio.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0002</DiagnosticId> | ||
<Target>M:System.Device.Gpio.PinEventTypes.#ctor</Target> | ||
|
Uh oh!
There was an error while loading. Please reload this page.