Add LPS22HB device #2309
Add LPS22HB device #2309
Conversation
2.1 Digital low-pass filter The LPS22HB embeds an additional low-pass filter that can be applied on the pressure readout path when the device is in continuous mode. https://www.st.com/resource/en/application_note/an4833-measuring-pressure-data-from-sts-lps22hb-digital-pressure-sensor-stmicroelectronics.pdf
src/devices/Lps22hb/README.md
Outdated
| - [x] Continus mode (25Hz) | ||
| - [x] BDU | ||
| - [x] Enable Low-pass filter |
There was a problem hiding this comment.
Looks a bit too good to me, when these items are checked but none of them are really available in the API as far as I can tell. What is BDU anyway?
There was a problem hiding this comment.
I added more available configuration.
The BDU (Block Data Update) is used to inhibit the update of the output registers between the reading of upper, middle and lower register parts
p20 => https://www.st.com/resource/en/application_note/an4833-measuring-pressure-data-from-sts-lps22hb-digital-pressure-sensor-stmicroelectronics.pdf
src/devices/Lps22hb/Lps22hb.cs
Outdated
| public void ResetDevice() | ||
| { | ||
| WriteByte(Register.CTRL_REG2, 0b0100); | ||
| while (true) |
There was a problem hiding this comment.
We should add a timeout otherwise, this is never ending or a cancellation token with a default value or a pattern with a number of addend and a delay, see
or even something like this:
Somehow your choice but you definitely need to addess the infinite loop problem.
There was a problem hiding this comment.
I arbitrarily added 100ms max, I've never seen a single loop I think it's enough.
Pipeline looks broken?
|
Yes, the mac build is currently broken. We're working on it. |
Adding LPS22HB based on existing LPS25H
https://www.st.com/resource/en/datasheet/lps22hb.pdf
Microsoft Reviewers: Open in CodeFlow