-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPIO support for Rockchip RV1103 #2303
Conversation
Hi @ZhangGaoxing great contribution, thank you.
|
Some datasheets can refer to the following link: https://wiki.luckfox.com/Luckfox-Pico/Datasheets/ |
I meant something a bit more detailed :-) The general guidelines applied to the rest of the repository are:
Thank you for the great work! |
[Triage] @ZhangGaoxing it would be perfect if you can address the feedback from @raffaeler. And we don't have the device to test or do anything with it. So please adjust a bit your PR and we will be super happy to review it and approve and of course merge it after. Thanks. |
[Triage] Hey @ZhangGaoxing your PR seems to be in a good state code-wise (thanks for the contribution!), but we think it needs some work in adding a few comments just to explain where some of the registers come from and where can we look at the docs. This is very important to us as it will help us maintain this driver going forward. Do you think you'll have cycles to do a quick pass over those? That way we can go ahead and take the change. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. |
Hello @ZhangGaoxing, the reviewers on this PR have requested changes and there has not been any activity for 14 days, so it will be closed for housekeeping pourposes. Feel free to reopen or send a new one if you wish to resume the progress. |
Add GPIO support for Rockchip RV1103 and some boards like LuckFox Pico.
I do some test in LuckFox Pico with pin 137, the OS is Ubuntu 22.04, Linux kernel version is 5.10.110, .NET version is 8.0.203. The GPIO speed is 219KHz
Microsoft Reviewers: Open in CodeFlow