Reorganize dependencies and infrastructure for ACS #2278
Conversation
pgrawehr
force-pushed
the
CompilerAsTool
branch
4 times, most recently
from
d7845cd
to
2e6a662
Compare
|
@joperezr Added extra notices as discussed. |
| <IsPackable>True</IsPackable> | ||
| <PackAsTool>True</PackAsTool> | ||
| <ToolCommandName>dotnet-acs</ToolCommandName> | ||
| <PackageOutputPath>..\..\..\artifacts\packages\$(Configuration)\Shipping</PackageOutputPath> |
There was a problem hiding this comment.
Why do you need to set this? This should be done automatically by Arcade.
There was a problem hiding this comment.
I don't know why, but it doesn't work otherwise (the package ends up in the local project's output folder)
| @@ -12,12 +12,15 @@ | |||
| <Compile Include="Program.cs" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ItemGroup Condition="$(Configuration)=='Debug'"> | |||
There was a problem hiding this comment.
I don't fully follow here why we use different P2Ps depending on the build config. Why can't we always just reference iot.device.bindings?
There was a problem hiding this comment.
Because the dependencies get really ugly for debugging and development in that case, as you would need to either link against the officially released package (which does not include the changes one might want to test) or rebuild the full package for every build. I've tried it, but it was impossible to work with.
| <Authors>The .NET Foundation community</Authors> | ||
| <NeutralLanguage>en</NeutralLanguage> | ||
| <IsPackable>True</IsPackable> | ||
| <PackAsTool>True</PackAsTool> |
There was a problem hiding this comment.
We should also make sure that this tool stays in preview and doesn't go stable (since it is experimental). You can accomplish that by adding the property: <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion> in the .csproj. This way, even when the rest of the repo builds stable packages, this tool will remain as prerelease.
However, this now includes a lot of code that's very likely not really used. Need to find a way around this.
This feature isn't used anywhere
So that compiling them works
For some reason, the linux build fails now due to these apparently missing.
Problem: Would pack with the previous release
Can still commit some, if useful
Better keep the low version as long as this is experimental
Make sure the release build only uses the official package, so that it can be used in client applications that don't build Iot.Device.Common from scratch. Due to the way the compiler works, the client application must be built against the exactly same library the compiler itself is built.
Also updates some test settings
Microsoft Reviewers: Open in CodeFlow