-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give better wiring instructions for 1-wire devices. #2258
base: main
Are you sure you want to change the base?
Conversation
The provided diagram is wrong (10k resistor is in series with the data line, leading to unreliable operation). I believe it was intended as a pullup (as recommended by the datasheet) However, since the pi IO pins are not 5v tolerant, to do that we need to pull up to 3.3v. To avoid confusion, we also power the sensor from 3.3v (the datasheet allows this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, but please delete the wrong schema image then.
@Hello1024 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Note: I took the liberty to move forward this documentation PR by adjusting the graphic and the source file. |
@Hello1024 you will have to accept the agrement, so that we can merge your PR with my adjustments once the pipelines will be green. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The drawing is still wrong. The resistor should be a pullup, but currently it is in-line with the data line. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
[Triage] @Hello1024: This would be ready to merge, but you need to agree to the license terms. Check the post from the dotnet-policy-service bot above. |
[Triage] @Hello1024 please accept the licence agreement so we can merge! Thanks a lot! |
The provided diagram is wrong (10k resistor is in series with the data line, leading to the device not working). I believe it was intended as a pullup (as recommended by the datasheet)
However, since the pi IO pins are not 5v tolerant, to do that we need to pull up to 3.3v.
To avoid confusion, we also power the sensor from 3.3v (the datasheet allows this).
This removes the incorrect wiring diagram.
Microsoft Reviewers: Open in CodeFlow