-
Notifications
You must be signed in to change notification settings - Fork 834
Prevent tailcalls when pinning locals; add regression coverage #19148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+44
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion coverage Co-authored-by: T-Gro <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issues with tail calls and pinned locals
Prevent tailcalls when locals are pinned or address-taken; add regression coverage
Dec 11, 2025
Member
|
/run test-baseline EmittedIL |
Contributor
✅ No release notes required |
Contributor
🔧 CLI Command Report
✅ Patch applied: |
T-Gro
reviewed
Dec 12, 2025
Co-authored-by: T-Gro <[email protected]>
Copilot
AI
changed the title
Prevent tailcalls when locals are pinned or address-taken; add regression coverage
Prevent tailcalls when pinning locals; add regression coverage
Dec 12, 2025
Member
|
/run test-baseline EmittedIL |
Contributor
🔧 CLI Command Report
✅ Patch applied: |
T-Gro
reviewed
Dec 15, 2025
T-Gro
approved these changes
Dec 16, 2025
abonie
approved these changes
Dec 16, 2025
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tail calls were still emitted when pinning locals (e.g.,
fixed &value), leading to corrupted results at runtime.Example:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.