Expand gitignore and fix line endings in AI chat template #5950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no *.in scripts in this repo currently, and this should avoid the following warning if you have autocrlf = true in your .gitconfig: PS C:\dev\temp\AIChat> dotnet new chat The template "AI Chat with Custom Data" was created successfully. PS C:\dev\temp\AIChat> git init Initialized empty Git repository in C:/dev/temp/AIChat/.git/ PS C:\dev\temp\AIChat> git add -A warning: in the working copy of 'AIChat.csproj', LF will be replaced by CRLF the next time Git touches it
RussKie
reviewed
Feb 21, 2025
...s/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/.gitignore
Show resolved
Hide resolved
RussKie
approved these changes
Feb 21, 2025
Some of these settings are artifacts from R9, which at some point in time was all in Unix line endings (despite never been worked on or run outside Windows). |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=958533&view=codecoverage-tab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing out
dotnet new chatand runningdotnet new gitignorehabitually, I saw that the template already created one for me. I was happy to see that it did, but I was surprised that it didn't account for build artifacts. This PR appends the gitignore used by the default item template which you can find here. I also made the*.dbexclusion narrower to apply just the ingestion cache SQLite database files, since even the default gitignore which includes a lot, doesn't assume you'd never want to check in a*.dbfile.I also have
autocrlf = trueconfigured in my personal .gitconfig, and I saw the following warning when first adding files generated by this template:I think this will be fixed by the .gitattributes change to use the default
text=autoinstead oftext eol=lffor*.infiles. As far as I can see, there are no other*.infiles currently in the extensions repo, so this should be safe.Microsoft Reviewers: Open in CodeFlow