[main] Source code updates from dotnet/dotnet #5473
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
|
@mikem8361 @tommcdon @hoyosjs can you please help us diagnose the CI failures? This is bringing in a new runtime, so could be that. |
|
@ViktorHofer - I haven't taken a look yet, but the VMR builds are lacking exports on the DAC. All debugger scenarios (tests and this repo) are on the ground |
|
We would appreciate guidance what needs to be done, especially if this also impacts P4 which ships from the VMR. cc @mmitche @jkoritzinsky |
|
@ViktorHofer - P4 is OK. This fixes for main dotnet/runtime#115309 |
[[ commit created by automation ]]
|
@hoyosjs can you please take another look? the fix has flown here now but there are still some test failures |
|
No the runtime fix hasn't yet flown here. I verified that earlier today. |
|
ah you're right sorry, my bad |
[[ commit created by automation ]]
|
ok it flowed now and all jobs except Windows x86 are green. @hoyosjs can you please take a look at that one? :) |
|
There is something wrong with x86 stack walking in the latest .NET 10 builds. We need to investigate further. |
|
The fix is a mix of dotnet/runtime#115405 and dotnet/runtime#115391 - mostly the former |
|
@hoyosjs @mikem8361 the latest dependency update has https://github.com/dotnet/runtime/commits/e67e997094b65c8ed7289b00f2304288d8f75a12 but there are still test failures (this time in MacOS x64). PTAL |
[[ commit created by automation ]]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25266.103 -> 10.0.0-beta.25229.109) Microsoft.NET.Sdk (Version 10.0.100-preview.5.25266.103 -> 10.0.100-preview.5.25229.109) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Runtime.win-x64, VS.Redist.Common.NetCore.SharedFramework.x64.10.0 (Version 10.0.0-preview.5.25266.103 -> 10.0.0-preview.5.25229.109)
[[ commit created by automation ]]
No dependency updates to commit
|
@hoyosjs it looks like tests are timing out now |
|
I noticed yesterday - it's SOS on breeding edge but hadn't had time to look. I'll try prioritizing this. |
[[ commit created by automation ]]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25269.109 -> 10.0.0-beta.25229.109) Microsoft.NET.Sdk (Version 10.0.100-preview.5.25269.109 -> 10.0.100-preview.5.25229.109) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.5.25269.109 -> 10.0.0-preview.5.25229.109)
This comment was marked as outdated.
This comment was marked as outdated.
[[ commit created by automation ]]
No dependency updates to commit
|
This is actually looking like a case where we don't get runtime startup: |
eng/Versions.props
Outdated
| <MicrosoftNETCorePlatformsVersion>10.0.0-preview.5.25229.109</MicrosoftNETCorePlatformsVersion> | ||
| <MicrosoftNETCoreAppRefVersion>10.0.0-preview.5.25229.109</MicrosoftNETCoreAppRefVersion> | ||
| <MicrosoftNETCorePlatformsVersion>10.0.0-preview.6.25272.109</MicrosoftNETCorePlatformsVersion> | ||
| <MicrosoftNETCoreAppRefVersion>10.0.0-preview.5.25266.103</MicrosoftNETCoreAppRefVersion> |
There was a problem hiding this comment.
@akoeplinger @ViktorHofer the rootcause seems to come from this. 103 is not a netcoreapp ref version. the xml has the right one. Any idea what happened here?
There was a problem hiding this comment.
This was a regression from #5486
There was a problem hiding this comment.
@mmitche - I assume this is what was intended
platform -> non-stable
ref -> stable version
For my learning - why is arch-specific asset not recommended for this?
There was a problem hiding this comment.
#5486 missed adding the entry for Microsoft.NETCore.App.Ref to Version.Details.xml so the version wasn't getting updated and you got a mix of versions.
For my learning - why is arch-specific asset not recommended for this?
The problem is when we build e.g. the win-x86 vertical then the Microsoft.NETCore.App.Runtime.win-x64 package isn't built so MicrosoftNETCoreAppRuntimewinx64Version would not be defined. Right now we have to manually inject properties like these with the correct value and we'd like to not have to do that.
|
This one is a DAC issue most likely: The obj itself is ok - has a good method table |
#5473 surfaced an issue of test resiliency. Per test we wait for a process to start and send a notification. If the process exits quickly, we'll wait for 5 min per test trying to see the message. This considers process exits as an error path eagerly.
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25272.109 -> 10.0.0-beta.25229.109) Microsoft.NET.Sdk (Version 10.0.100-preview.6.25272.109 -> 10.0.100-preview.5.25229.109) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.6.25272.109 -> 10.0.0-preview.5.25229.109) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp (Version 5.0.0-1.25272.109 -> 4.11.0-2.24271.11) Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25272.109 -> 3.12.0-beta1.24605.1) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25272.109 -> 10.0.0-preview.24605.1)
[[ commit created by automation ]]
No dependency updates to commit
[[ commit created by automation ]]
No dependency updates to commit
|
@hoyosjs looks like only the |
|
Yeah, I've been looking but it might take a bit. |
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies