-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package servicing doc #9707
Conversation
release-policies.md
Outdated
* The package exclusively includes implementations for out-of-support .NET versions. | ||
|
||
Nuget.org includes [version](https://www.nuget.org/packages/System.Text.Json/#versions-body-tab) and [supported framework](https://www.nuget.org/packages/System.Text.Json/#supportedframeworks-body-tab) information that can be used to determine support status for packages. | ||
|
||
## Support requirements | ||
|
||
To remain supported, you must do the following: | ||
|
||
* Use a supported SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest linking to the .NET landing page so that customers can see which versions are currently in support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a thought, but LTGM otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the one comment and otherwise lgtm!
|
||
Apps only ever need a package reference to one of these libraries to use a newer major version. It is more common for libraries to have a reference, particularly .NET Standard libraries. | ||
|
||
The following libraries use this servicing model: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add EF Core here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lists are not intended to be exhaustive. However, 3-6 examples would be great. Feel free to add in more via suggestion. It seems like an exhaustive list should be provided via a different approach. Same applies to your other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if instead we could have a plan to represent this state somehow in the nuget gallery?
For instance -- through the support metadata -- or by observing the release cadence. Feels like it will be hard to make an exhaustive list here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea we had last week in a meeting in this area was:
- Mark old package versions as "deprecated" on nuget.org. (for example, all System.Text.Json 7.0.x versions would be marked as deprecated today.)
- Add tooling to let you know when you are using something is not supported any longer.
This way, you could see that the 8.x and 9.x versions were still in support. But the 7.x version isn't.
For "Latest version servicing" like .NET Aspire all 8.x versions would be marked as "deprecated".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exhaustive list
I'm not suggesting this list be exhaustive of all packages. What I am suggesting is to document the groups of packages that follow the same model. All Runtime, ASP.NET Core, EF Core follow this model. All Extensions, Aspire, ML.NET follow latest version model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to write a doc for EF (in the EF repo) and we can link to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love for support level to be exposed via the NuGet gallery and the NuGet API/client. That's clearly the best model. That's a good idea to follow merging this PR.
@richlander Long thread here. Would you please summarize the ask for us and open an issue in NuGet/Home?
cc @OliaG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask: There should be an E2E for deprecated/unsupported packages from producer marking existing packages as such and consumers getting warnings via the gallery, VS, and the NuGet/dotnet CLI. A team like ours isn't going to use the gallery to mark our packages as deprecated. We need an API for that (we're talking to @joelverhagen about that part). I can open an issue if there isn't one on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That appears to be a match and I remember it now. Good find.
FYI: @JonDouglas
|
||
Apps only ever need a package reference to one of these libraries to use a newer major version. It is more common for libraries to have a reference, particularly .NET Standard libraries. | ||
|
||
The following libraries use this servicing model: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help to add dotnet/aspnetcore packages here as well? For example, Microsoft.AspNetCore.SignalR.Client
and Microsoft.Extensions.Diagnostics.HealthChecks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk about HealthChecks, but SignalR.Client is not part of the shared framework, so it always requires a package reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(some) Asp.NET packages are a special case of per-version servicing. I think in that case you must use the version that matches the .NET Version. They don't support other frameworks (like NetStandard, NETFramework, or the oldest LTS).
Then there's the old 2.x packages which do and follow "latest" servicing.
|
||
- [.NET Aspire](https://github.com/dotnet/aspire) | ||
- [ML.NET](https://github.com/dotnet/machinelearning) | ||
- [Maintenance-packages](https://github.com/dotnet/maintenance-packages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add dotnet/extensions here as well.
See https://dotnet.microsoft.com/en-us/platform/support/policy/extensions
One recurring point of confusion is that we have Microsoft.Extensions.*
packages with different support models based on the repo it comes from. For MS.Ext libraries coming from runtime and aspnetcore, it uses Runtime-band servicing. For MS.Ext libraries in dotnet/extensions, it uses "Latest version servicing".
|
||
Apps only ever need a package reference to one of these libraries to use a newer major version. It is more common for libraries to have a reference, particularly .NET Standard libraries. | ||
|
||
The following libraries use this servicing model: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk about HealthChecks, but SignalR.Client is not part of the shared framework, so it always requires a package reference.
Co-authored-by: Eric Erhardt <[email protected]>
.NET packages are no longer supported when either of the following occurs: | ||
|
||
- A new patch version of the package is available. | ||
- The package exclusively includes implementations for out-of-support .NET versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a package still supported if one of its (transitive) dependencies is not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be a problem for that package to fix - more like an SDL issue for that package. Not something the customer is supposed to worry about.
Co-authored-by: Rich Lander <[email protected]>
Co-authored-by: Rich Lander <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a difficult topic that will always have more we can say. I think this does a good job of giving an outline without trying to explain the world.
No description provided.