-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Enable IJSObjectReference to handle null/undefined values #62657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ilonatommy
merged 8 commits into
dotnet:main
from
rolandVi:jsobjectreference-handle-null
Jul 14, 2025
Merged
Enable IJSObjectReference to handle null/undefined values #62657
ilonatommy
merged 8 commits into
dotnet:main
from
rolandVi:jsobjectreference-handle-null
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroztocil
reviewed
Jul 10, 2025
src/JSInterop/Microsoft.JSInterop/test/Infrastructure/JSObjectReferenceJsonConverterTest.cs
Show resolved
Hide resolved
Please check that you get an expected result when you do
|
ilonatommy
reviewed
Jul 14, 2025
src/Components/test/testassets/BasicTestApp/InteropComponent.razor
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Jul 14, 2025
… + fixed E2E tests
Removed unwanted `AspNetCore.slnx` entry
…landVi/aspnetcore into jsobjectreference-handle-null
oroztocil
reviewed
Jul 14, 2025
src/Components/test/testassets/BasicTestApp/InteropComponent.razor
Outdated
Show resolved
Hide resolved
ilonatommy
approved these changes
Jul 14, 2025
oroztocil
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-blazor
Includes: Blazor, Razor Components
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable IJSObjectReference to handle null/undefined values
Problem
Currently, calling
DotNet.createJSObjectReference(null)
orDotNet.createJSObjectReference(undefined)
throws an error: This forces developers to write workaround code when JavaScript functions might return null/undefined values.Solution
Modified
createJSObjectReference
to handle null/undefined values by returning a special sentinel object with__jsObjectId: -1
instead of throwing an error. The .NET side JSON converter recognizes this sentinel value and returnsnull
for theIJSObjectReference?
.Changes
createJSObjectReference()
now accepts null/undefined and returns{__jsObjectId: -1}
JSObjectReferenceJsonConverter
recognizes the-1
sentinel and returnsnull
disposeJSObjectReference()
to safely handle null references (skip disposal for id-1
)Benefits
Fixes #52070