Update NuGet global packages cache detection #14763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to account for per-user NuGet.Config as a way to configure the location of the global packages cache. Avoid setting NuGetPackageRoot in RepoLayout.props because it is already being set to the correct location in the *.nuget.g.props files created for each project. Fixes dotnet#14761
|
I'm not sure how to get this change over in the branch of Arcade used by Roslyn. |
tmat
reviewed
May 13, 2024
| @@ -19,6 +19,10 @@ | |||
| Writes a stub file to component intermediate directory. | |||
| --> | |||
|
|
|||
| <PropertyGroup> | |||
There was a problem hiding this comment.
VisualStudio.props is imported before the *.nuget.g.props files that define NuGetPackageRoot. I had to move this usage of the property to VisualStudio.targets so it resolves to the correct non-empty value.
|
@tmat for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to account for per-user NuGet.Config as a way to configure the location of the global packages cache.
Fixes #14761