Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AzureStorageTargetFeedPAT #14208

Open
wants to merge 5 commits into
base: release/6.0
Choose a base branch
from

Conversation

epananth
Copy link
Member

@epananth epananth commented Nov 7, 2023

To double check:

Issue -> #13963

@epananth epananth self-assigned this Nov 7, 2023
@epananth epananth requested a review from mmitche November 7, 2023 22:02
mmitche
mmitche previously approved these changes Nov 7, 2023
@akoeplinger
Copy link
Member

There's a build failure:

src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigV3.cs(61,15): error CS7036: There is no argument given that corresponds to the required formal parameter 'azureDevOpsFeedsKey' of 'SetupTargetFeedConfigBase.SetupTargetFeedConfigBase(bool, bool, string, string, string, bool, string, string, string, string, string, string, string, string, string)'

Remove used of scoped ref
@mmitche
Copy link
Member

mmitche commented Nov 15, 2023

@missymessa The 6.0 SDK doesn't have a new enough compiler for scoped, I think.

@missymessa
Copy link
Member

@missymessa The 6.0 SDK doesn't have a new enough compiler for scoped, I think.

Odd, it compiles for me locally. I think we need to rethink our approach here. There's a bit of a divergence between all versions involved, even around the tests, that I'm concerned about ensuring parity between all versions as we refactor out this value.

@mmitche
Copy link
Member

mmitche commented Nov 15, 2023

The swagger generator and most of the publishing code is actually not used outside of main. We probably could delete a lot of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants