Asm diff updates #13641
Asm diff updates #13641
Conversation
…lightInterfaceImplementations". Update Readme to reflect this. Add extra boolean checks for the newly split options.
There was a problem hiding this comment.
@carlossanlop as your changes touch Cci.Extensions which is used by ApiCompat and GenAPI and I don't see any tests running for Cci.Extensions, can you please test your changes in places that use these tools? Presumably, AsmDiff is only used by you but CCI GenAPI is used in runtime and CCI ApiCompat is used in a few other repositories.
|
@carlossanlop are you still working on this? |
|
@missymessa It's probably ready to merge, but it also needs a good review and making sure we don't break anything that consumes Cci that we're unaware of. But it's super low priority right now. My team will review it eventually. Also, I occassionally add extra commits whenever I find bugs when running the api-diff tool. Do you mind if we keep it open? |
|
Maybe merge right after GA? |
|
Yes, we'll try to merge after GA. And if it's messing up with your metrics, I don't mind closing the PR and keep pushing my branch. When ready, I can create a new PR. Does that sound better? |
|
Sounds good! Noticed this was a little stale of a PR, but it's not causing any concern with metrics. :) |
Some fixes I've done over the few last months to address common problems in the API diff PRs. The main fix is related to the way we show APIs that had attribute changes.
No one else uses ApiDiff or Cci, that we know of, so please consider taking this change.