Customize binary log name #12988
Open
Customize binary log name #12988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no easy way to customize the binary log name when using build.ps1 today. That means you can't have a different binary log for build and restore steps. Add a name parameter so it can be customized.
jjonescz
reviewed
Mar 30, 2023
| @@ -93,7 +95,7 @@ function Build { | |||
| $toolsetBuildProj = InitializeToolset | |||
| InitializeCustomToolset | |||
|
|
|||
| $bl = if ($binaryLog) { '/bl:' + (Join-Path $LogDir 'Build.binlog') } else { '' } | |||
| $bl = if ($binaryLog) { '/bl:' + (Join-Path $LogDir $binaryLogName) } else { '' } | |||
There was a problem hiding this comment.
Seems it's possible to pass another /bl: flag with a custom name today:
https://github.com/dotnet/sdk/blob/ec824c9797659318c772330cb176286643a25dfe/eng/build.yml#L91
Although you still have to provide full path.
There was a problem hiding this comment.
There are a few issues with using /bl
- It feels a bit broken. It's essentially using a trick that
/won't be picked up by PowerShell so it falls through to the extra args. - Consider that
-ciwill effectively force$binaryLogto be$true. That means the line here gets invoked and added to the argument list. Today that works because it gets added first so the/blflag we add wins but this could easily get broken if later on the argument order is reversed. - As you noted it requires us to provide the full path. That feels like it breaks the arcade abstraction a bit. If they decide to later on change the layout of artifacts then our scripts are broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no easy way to customize the binary log name when using build.ps1 today. That means you can't have a different binary log for build and restore steps. Add a name parameter so it can be customized.
To double check: