Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in directory name #30498

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

timdeschryver
Copy link
Contributor

@timdeschryver timdeschryver commented Sep 27, 2023

Coming from #27865 (comment)

This PR fixes a typo in the directory name (diagonstics => diagnostics).
After this PR, the "base" is good to pick up the other issues without interrupting each other.

Should be merged together with dotnet/AspNetCore.Docs.Samples#192


Internal previews

馃搫 File 馃敆 Preview link
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rg002.md RDG002: Unable to resolve endpoint handler

@Rick-Anderson
Copy link
Contributor

@tdykstra had the same comment, I'm not seeing that. https://learn.microsoft.com/en-us/aspnet/core/fundamentals/aot/request-delegate-generator/diagnostics/rdg002?view=aspnetcore-8.0 is rendering correctly and you version isn't finding the snippets.

@Rick-Anderson
Copy link
Contributor

From the build report
image

I do have to change the UID on all these from rdgxxx to rgxxx per the source code.

@timdeschryver
Copy link
Contributor Author

timdeschryver commented Sep 27, 2023

The reason why it's rendered correctly on the live learn website is because the samples are added to the directory containing the typo (diagonstics).
In other words, the typo exists within this repo and the samples repo.

The current state of this PR fails because it cannot find the snippets due to the rename within the docs, but not in the samples repo.

To fix the build (at least how I see it, and feel free to correct me), I think the PR of the samples repo needs be merged first (dotnet/AspNetCore.Docs.Samples#192) because it fixes the typo within that repo.

After the samples PR is merged this PR will successfully build because it can now find the files.

I tested this on my local machine (it works on my machine 馃槄)
image

@Rick-Anderson
Copy link
Contributor

@timdeschryver can you change all the rdg00x to rg00x like I did in https://github.com/dotnet/AspNetCore.Docs/pull/30499/files, that will get rid of the merge conflict. I had to change that to generate the correct URL

@Rick-Anderson
Copy link
Contributor

Actually, it's a file rename that needs to happen, drop the d in the file name

@Rick-Anderson Rick-Anderson merged commit 767819f into dotnet:main Sep 27, 2023
3 checks passed
@timdeschryver
Copy link
Contributor Author

Sorry, I was just leaving. Thanks for the fixup!

@timdeschryver timdeschryver deleted the typo-in-directory-name branch September 27, 2023 18:43
@Rick-Anderson
Copy link
Contributor

Thanks for fixing this. @tdykstra notified me of the same problem and I couldn't see it, ha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants