-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store and handle more user attributes #871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikskog
force-pushed
the
user-attributes
branch
from
April 12, 2024 17:56
b2e6643
to
97a0cec
Compare
henrikskog
force-pushed
the
user-attributes
branch
from
April 12, 2024 19:06
fad8767
to
e5e7948
Compare
henrikskog
changed the base branch from
main
to
fix/attendance-merge-race-condition
April 12, 2024 19:07
henrikskog
force-pushed
the
user-attributes
branch
from
April 12, 2024 19:15
e5e7948
to
2a7bff1
Compare
henrikskog
changed the title
user attributes
User Attributes Issue 2: Fake user attributes and implement handling of user with all attributes
Apr 12, 2024
henrikskog
force-pushed
the
fix/attendance-merge-race-condition
branch
2 times, most recently
from
April 14, 2024 14:17
9d8fac3
to
cedde34
Compare
henrikskog
force-pushed
the
user-attributes
branch
from
April 14, 2024 14:22
2a7bff1
to
d024732
Compare
junlarsen
requested changes
Apr 28, 2024
@@ -249,7 +248,6 @@ export const createServiceLayer = async ({ db }: ServerLayerOptions) => { | |||
attendeeService, | |||
interestGroupRepository, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated but this should probably not be here (cc @Terbau)
packages/core/src/modules/user/auth0-synchronization-service.ts
Outdated
Show resolved
Hide resolved
henrikskog
changed the title
User Attributes Issue 2: Create CRUD for all user attributes synced between auth0 and local db
Store and handle domain user attributes
Apr 28, 2024
junlarsen
approved these changes
Apr 28, 2024
henrikskog
changed the title
Store and handle domain user attributes
Store and handle more user attributes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For how user data is stored in auth0 (some properties are stored in
app_metadata
and some inuser_metadata
, see:monoweb/packages/core/src/modules/external/auth0-repository.ts
Line 17 in 7aced04
I have added a function that inserts fake data for the new fields until we gather this on signup such that we can maintain the not-null integrity of these fields thorughout the backend. See
monoweb/packages/auth/src/auth-options.ts
Line 77 in 7aced04