Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unnecessary peer dependencies #3790

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Cleanup unnecessary peer dependencies #3790

merged 2 commits into from
Feb 20, 2025

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Feb 20, 2025

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 2421bbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/nestjs-federation Patch
@graphql-yoga/plugin-apollo-usage-report Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://8ddd3baf.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Feb 20, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 525452      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 106 MB  704 kB/s
     http_req_blocked.............................: avg=1.56µs   min=1.03µs   med=1.34µs   max=5.91ms   p(90)=2.01µs   p(95)=2.22µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=140.3µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=354.7µs  min=207.58µs med=323.48µs max=18.29ms  p(90)=464.59µs p(95)=488.05µs
       { expected_response:true }.................: avg=354.7µs  min=207.58µs med=323.48µs max=18.29ms  p(90)=464.59µs p(95)=488.05µs
     ✓ { mode:graphql-jit }.......................: avg=281.25µs min=207.58µs med=264.82µs max=18.29ms  p(90)=298.23µs p(95)=314.06µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=490.28µs min=403.52µs med=467.03µs max=10.23ms  p(90)=514.54µs p(95)=568.62µs
     ✓ { mode:graphql-response-cache }............: avg=340.89µs min=262.36µs med=323.39µs max=6.46ms   p(90)=358.48µs p(95)=375µs   
     ✓ { mode:graphql }...........................: avg=359.88µs min=273.91µs med=333.62µs max=13.8ms   p(90)=385.21µs p(95)=429.92µs
     ✓ { mode:uws }...............................: avg=339.66µs min=261.06µs med=321.67µs max=6.58ms   p(90)=359.85µs p(95)=388.46µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 262726
     http_req_receiving...........................: avg=33.14µs  min=15.96µs  med=32.61µs  max=2.57ms   p(90)=39.98µs  p(95)=43.65µs 
     http_req_sending.............................: avg=8.61µs   min=5.93µs   med=7.47µs   max=784.22µs p(90)=11.1µs   p(95)=12.34µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=312.94µs min=179.57µs med=282.86µs max=18.18ms  p(90)=422.34µs p(95)=443.65µs
     http_reqs....................................: 262726  1751.492323/s
     iteration_duration...........................: avg=565.98µs min=383.95µs med=530.3µs  max=18.78ms  p(90)=679.2µs  p(95)=708.6µs 
     iterations...................................: 262726  1751.492323/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@ardatan ardatan merged commit 1d438ce into main Feb 20, 2025
25 checks passed
@ardatan ardatan deleted the fix-peer-deps branch February 20, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant