fix europa league teams colors #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! thank you for this PR, looks good! You can check out how the naming is done here, https://the-odds-api.com/liveapi/guides/v4/#get-participants. Might have to play around with it using a free API key and see which teams are available |
|
Let me know here, if you end up not being able to add more teams and I will just go ahead and merge, thanks! |
|
@digiorgiu just pinging in case you didn't see this^ |
|
Hey! Thank you very much for your answer! Since I can get exact name of European Teams, I am going to organize them by their National League. Is it ok for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Europa League Teams Colors
I have added the missing colors for the Europa League teams that are still in the current (2024/2025) tournament. This ensures all teams have accurate and updated colors.
P.s: If I may suggest, it would be better to add the European Teams ordered by national leagues (how is already done for EPL and La Liga). I followed instead the <// UEFA Champions League Teams (additional from various leagues)> approach, working but not the best because. I wasn't able to add the European Major Leagues Teams (Serie A, Bundesliga, Ligue1, Eredivisie etc ect) because I don't know exactly how each team is named in your API. If you may provide this data to me (or where I can get it) I will add Teams orderd by their National Leagues and so they become automatically available for Champions League, Europa League and Conference League.
Thank you