cli_common: Fix wait_return availability on Windows #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wondering why not just end the process without waiting for a signal or input - this seems to be more efficient and elegant |
|
The main reason someone else created this PR to change it from |
|
Understood. Since we don't have an alternative to Some of my ideas:
|
|
@mic12130 i'm okay with your suggested PR, just fix the linting issues |
doronz88
force-pushed
the
fix/wait-return-on-win
branch
from
9d09c00 to
0d262a2
Compare
doronz88
changed the title
wait_return availability on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As sigwait is only available on Unix, running some services on Windows can result in errors like this comment
It's more common to use Enter to exit processes instead of Ctrl+C on Windows, so I reverted the behavior on Windows to what it was before #680
This PR needs to be tested along with #797 for now since Windows support is not yet on master.