crash_reports: add optional timeout to get_new_sysdiagnose
#776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenGemin
commented
Jan 10, 2024
StephenGemin
force-pushed
the
bugfix/sysdiagnose-timeout
branch
from
d0fae21 to
a5789fb
Compare
doronz88
requested changes
Jan 11, 2024
StephenGemin
force-pushed
the
bugfix/sysdiagnose-timeout
branch
from
a5789fb to
0ee8664
Compare
doronz88
requested changes
Jan 16, 2024
StephenGemin
force-pushed
the
bugfix/sysdiagnose-timeout
branch
from
0ee8664 to
06de161
Compare
* on timeout raise error `SysdiagnoseTimeoutError`
StephenGemin
force-pushed
the
bugfix/sysdiagnose-timeout
branch
from
06de161 to
a7ed5be
Compare
doronz88
requested changes
Jan 17, 2024
|
|
||
| @pytest.mark.parametrize( | ||
| ('end_time', 'return_value'), | ||
| ((-1, True), (0, True), (10, False), (None, False)) |
There was a problem hiding this comment.
Hey @doronz88 , is there a way that I can contribute to this PR?
There was a problem hiding this comment.
Feel free to fix this test yourself
There was a problem hiding this comment.
Ok, but that will create a new PR, won't it? I was thinking on this PR, which I cannot edit (or it seems so)
|
Hey @StephenGemin , I find this PR very interesting to be added. But I just realised that the PR #847 I submitted, even if complementary, may yield conflicts when trying to incorporate yours. Please take a look to the new code of get_new_sysdiagnose. Looking forward to having your PR on the master branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any issues collecting sysdiagnose archive, it could potentially hang at this API. This provides a backwards compatible way for fully automated (and unmonitored) test applications to continue with execution.
Updates
timeoutkeyword toget_new_sysdiagnosesignatureSysdiagnoseTimeoutError