fix(window-select): load winum earlier #7848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that a user can use `winum-auto-setup-mode-line` with value `t`. Since that modifies the default mode line, the entire package needs to be loaded very early for that option to be available to a user. This is cheaper and better than mapping over every buffer and modifying their buffer-local value for mode-line-format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that a user can use
winum-auto-setup-mode-linewith valuet. Since that modifies the default mode line, the entire package needs to be loaded very early for that option to be available to a user.This is cheaper and better than mapping over every buffer and modifying their buffer-local value for mode-line-format.
Also, I disagree with that comment in the sense that modifying
mode-line-formatis not important at all since it is done correctly. The issue to me is that since it modifies the default value ofmode-line-format, the package should be loaded early for all buffers to have that mode-line segment.