Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ocaml): add more extra ligatures #7809

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dev380
Copy link
Contributor

@Dev380 Dev380 commented Apr 11, 2024

Tuareg mode (for ocaml) current uses
its own ligatures. This extends that
with some extra, non-conflicting ones
using the :ui ligatures module's
pre-defined ligatures.


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.

Before:
20240410_21h33m24s_grim

After:
20240410_21h32m05s_grim

I'm using the dot instead of the cartesian product sign for the tuple type because it uses the * character, which is also used for multiplication. One way to resolve this is to add the cross product symbol to the default +ligatures-extra-symbols plist as a compromise between X for multiplication and X for cartesian product. I'm not sure if this is optimal, though, should this be done?

I added the tuple symbol just for the screenshot, but I might remove it because of how hacky it is (matches on ", " to avoid it being lopsided, but then tuples not in that format won't work + there are no spaces on each side).

Tuareg mode (for ocaml) current uses
its own ligatures. This extends that
with some extra, non-conflicting ones
using the `:ui ligatures` module's
pre-defined ligatures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant