Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default timetrace list records to the current date #125

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Default timetrace list records to the current date #125

wants to merge 5 commits into from

Conversation

aligator
Copy link
Collaborator

This sets the default date of timetrace list records to the current date to make it easy to just get the records from the current day.

@aligator aligator force-pushed the default-list-today-records branch from 202237b to ff3c6d9 Compare June 13, 2021 18:43
@dominikbraun dominikbraun self-requested a review June 13, 2021 19:05
dominikbraun
dominikbraun reviewed Jun 14, 2021
View reviewed changes
Copy link
Owner

@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick suggestion 😄

cli/list.go Outdated Show resolved Hide resolved
@aligator aligator requested a review from dominikbraun June 14, 2021 18:58
@dominikbraun dominikbraun added this to the timetrace v0.12.0 milestone Jun 18, 2021
@dominikbraun dominikbraun mentioned this pull request Jun 18, 2021
Open
dominikbraun
dominikbraun requested changes Jun 28, 2021
View reviewed changes
Copy link
Owner

@dominikbraun dominikbraun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the change needs to be documented in the command syntax and in README.md.

@aligator
Copy link
Collaborator Author

@dominikbraun
Added it to the readme and refactored it a bit by just setting the value to 'today' instead of passing a new date.

@aligator aligator requested a review from dominikbraun June 30, 2021 18:51
@dominikbraun dominikbraun modified the milestones: timetrace v0.12.0, timetrace v0.14.0 Jul 7, 2021
@dominikbraun dominikbraun removed this from the timetrace v0.14.0 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbraun dominikbraun Awaiting requested review from dominikbraun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aligator @dominikbraun