Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Domenic,
First, thanks a ton for all the work you do on ES, Node, and the like. I enjoy my work and field in part because of you!
This workshop is great, too. As part of an ongoing effort in nodeschool/organizers#64 to localize all known workshops so as to reduce friction for traditionally "English-impaired" communities (e.g. FR 😞), I've been upgrading all
workshopper
-based workshops to the latest, g11n-capable versions of the infra, and upgrading their codebase to fit.I also took the liberty to tweak your problem Markdown files a bit to better fit with well-established (by now) best practices, such as ~80-character wrapping, well-known headings, etc. Because this is more of a stylistic thing, I put that in a separate commit, but I hope you'll agree with the intent.
I'm trying to get the FR L10n for this in today (it would be great to have the npm module ready for tomorrow's first NodeSchool Paris event), but I must finish translating a fork of
stream-adventure
first, so it might not get in before Monday… We'll see.I am, of course, available for any discussion on this.
Best,