Skip to content

Resolves issue-102 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Resolves issue-102 #104

wants to merge 1 commit into from

Conversation

corytodd
Copy link

The SEGFAULT string generated by the compiler was falling through the
success check in execProcAsync. Add a new string and to match SIGSEGV and add corresponding elif to mark compileSuccess as false.

This is tested Debian 8.

Create a simple binary:

echo "old bin"

Run "Compile and run current file" through Aporia

Now add some segfaulty stuff. This is a snippet from Nim issue 4003:

echo "new bin"

proc boo(p: proc)

proc quux(p: proc) =
    discard

proc boo(p: proc) =
  discard

Prior to this patch, executing "Compile and run current file" would show a segfault message and then run the old bin resulting in "old bin" printing in the output window. The patched version shows the segfault message and quits.

Fixed #102

The SEGFAULT string generated by the compiler was falling through the
success check in execProcAsync. Add a new string and to match SIGSEGV and add corresponding elif to mark compileSuccess as false.
@dom96
Copy link
Owner

dom96 commented Mar 28, 2016

This seems kind of hackish, I think the underlying issue is that osproc doesn't think the Nim process returned with an exit code of 1. So osproc needs to be fixed.

@dom96 dom96 closed this Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants