Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoInterface: Cleanup and minor fix in Update. #13396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

VideoInterface: Cleanup and minor fix in Update. #13396

wants to merge 1 commit into from

Conversation

jordan-woyak
Copy link
Member

Notably, GetHalfLinesPerEvenField was used to calculate the even field boundary.
I think that should be GetHalfLinesPer*Odd*Field, though they are probably usually the same?

Other minor cleanups.

iwubcode
iwubcode approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up. LGTM. Untested.

Dentomologist
Dentomologist approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Dentomologist Dentomologist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to make a very similar PR but wanted to double check I wasn't misunderstanding when the odd/even fields were happening, so +1 on the logic change making sense.

LGTM, briefly tested with a couple games and nothing exploded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

@Dentomologist Dentomologist Dentomologist approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordan-woyak @iwubcode @Dentomologist