Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoInterface: Adjust even-field to match odd-field pacing when PSB values differ. #13394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordan-woyak
Copy link
Member

@jordan-woyak jordan-woyak commented Mar 4, 2025

This fixes a frame pacing problem in many GC games that becomes apparent with the improvements of #13387

Super Mario Sunshine:

(VI->BeginField): Address: 004C8D80 | WPL 40 | STD 80 | EQ 6 | PRB 40 | ACV 224 | PSB 19 | Field Odd
HorizScaling: 0100 | fbwidth 640 | 8108100 | 8108100
(VI->BeginField): Address: 004C8D80 | WPL 40 | STD 80 | EQ 6 | PRB 41 | ACV 224 | PSB 18 | Field Even
HorizScaling: 0100 | fbwidth 640 | 8108100 | 8108100

Odd/Even PRB/PSB values differ and we present before PSB causing bad pacing between odd/even fields.

Before:
image
image

After:
image
image

Just a side note: these values are state-saved so comparisons cannot be done if you are loading a state. :)
Also, you really won't be able to observe a difference without #13387

@jordan-woyak jordan-woyak changed the title VideoInterface: Adjust even-field to match odd-field pacing when PRB values differ. VideoInterface: Adjust even-field to match odd-field pacing when PSB values differ. Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant