CoreTiming: Allow forcing seek of accurate overall emulation time. #13392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
frame-pacing-accurate-time
branch
3 times, most recently
from
7a2158a to
d5e08ec
Compare
|
Ugh, not directly related to this PR but we really should move all those text descriptions from the advanced tab to tooltips or similar. It's already stupidly tall and will get even taller with the fallback timing option... |
accurate emulation time.
jordan-woyak
force-pushed
the
frame-pacing-accurate-time
branch
from
d5e08ec to
4e61ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this ties in with PR #13387 which should probably be merged first.
Previous
Throttlecode adjusted time points every call leading to potential rounding errors and accumulated drift over time.Time points are now adjusted by exact seconds to avoid this.
MAIN_MAX_FALLBACK(default: 100ms) has already existed to reset the throttle if emulation strays too far from the target time, such as from a CPU bottleneck.If stutters exceeds 100ms before Dolphin can catch up, it will adjust the reference time and effectively commit to running >100ms in the past.
That is not ideal for internet play and a user has reported it as a cause of issue with Wiimmfi.
https://bugs.dolphin-emu.org/issues/13609 (fixed)
The
MAIN_MAX_FALLBACKvalue can now be adjusted in the UI and set to zero to always seek accurate overall emulation time.