Open LDAP early, otherwise user-manager is not available. #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotdrop
force-pushed
the
bugfix/authldap-usermanager
branch
from
6f2753a
to
d9f67f5
Compare
rotdrop
force-pushed
the
bugfix/authldap-usermanager
branch
from
d9f67f5
to
77dc471
Compare
|
Anyone with LDAP experience who could review this? Seems logic because |
rotdrop
force-pushed
the
bugfix/authldap-usermanager
branch
3 times, most recently
from
ab1fa0a
to
5c4cce7
Compare
rotdrop
force-pushed
the
bugfix/authldap-usermanager
branch
from
5c4cce7
to
53b3bf8
Compare
Ideally a connection to ldap would only be opened when needed. Eg, if I am not logged in, there is no need to connect to LDAP. I think it would make more sense to simply set the cando capability in the constructor, even if a connection might fail later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call openLDAP() early, seemingly
$this->cando['getUsers']is set too late such that the user-manager in the admin panel is not made available.