Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new builds plugin #3697

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add new builds plugin #3697

wants to merge 4 commits into from

Conversation

josegonzalez
Copy link
Member

@josegonzalez josegonzalez commented Sep 24, 2019 •
edited

Todo:

  • Send output from any deploy-related command to logger
  • Move ps:kill-deploy to builds:cancel
  • Add builds/builds:list command which shows all currently running deploys
  • Add builds:info $APP command which shows the status of that deploy, buildpacks in use, and the date the deploy started (and ended?)
  • Add builds:output $APP command which tails the logs of a given deploy

Related: https://github.com/heroku/heroku-builds

@josegonzalez josegonzalez changed the title Add new deploys plugin Add new builds plugin Oct 8, 2019
@miguelcobain miguelcobain mentioned this pull request Oct 9, 2020
Open
@josegonzalez josegonzalez added this to In Progress in Release Board Dec 2, 2020
@josegonzalez josegonzalez mentioned this pull request Jan 6, 2023
Closed
@josegonzalez josegonzalez force-pushed the track-deploys branch 2 times, most recently from 8f432d1 to 613a285 Compare September 10, 2023 03:32
@josegonzalez josegonzalez changed the base branch from master to 0.32-release September 10, 2023 03:32
@josegonzalez josegonzalez added this to the v0.32.0 milestone Oct 15, 2023
@josegonzalez josegonzalez modified the milestones: v0.32.0, v0.33.0 Oct 16, 2023
Base automatically changed from 0.32-release to master October 17, 2023 04:55
@josegonzalez josegonzalez modified the milestones: v0.33.0, v0.34.0 Jan 20, 2024
@josegonzalez josegonzalez mentioned this pull request Mar 13, 2024
Merged
@josegonzalez josegonzalez changed the base branch from master to 0.34-release March 14, 2024 10:09
@josegonzalez
feat: implement build tracking
d6f0937 
The DOKKU_PID now never gets overwritten except in the case that DOKKU is executed by the sudo user. If the command ends up executing a deploy, then the pid of the `dokku` owned process - which may have been executed via sudo - will be written to the file lock, allowing future commands to interact with the original process.

Additionally, the new builds plugin can be used to handle killing a build.
@josegonzalez
fix: correct issue with cancel
777541c
@josegonzalez
feat: implement builds:output
772c31d 
This still needs tightening to ensure we don't trigger this for normal git plugin commands - as well as anything that triggers a deploy - but works in a pinch.
@josegonzalez
feat: redirect output in every case as appropriate
c7b2f1e
@josegonzalez josegonzalez modified the milestones: v0.34.0, v0.35.0 Mar 18, 2024
Base automatically changed from 0.34-release to master March 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-level: minor type: enhancement
Projects
No open projects
Release Board
In Progress
Milestone
v0.35.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@josegonzalez