Skip to content

Commit

Permalink
Fixes #17165: during a scroll animation, touchstart should not trigge…
Browse files Browse the repository at this point in the history
…r the selection of the item
  • Loading branch information
Adrian Vasiliu committed Mar 7, 2014
1 parent 54bb4db commit 84e9020
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion mobile/_ItemBase.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ define([
"./TransitionEvent",
"./iconUtils",
"./sniff",
"./viewRegistry",
"dojo/has!dojo-bidi?dojox/mobile/bidi/_ItemBase"
], function(array, declare, lang, win, domClass, touch, registry, Contained, Container, WidgetBase, TransitionEvent, iconUtils, has, BidiItemBase){
], function(array, declare, lang, win, domClass, touch, registry, Contained, Container,
WidgetBase, TransitionEvent, iconUtils, has, viewRegistry, BidiItemBase){

// module:
// dojox/mobile/_ItemBase
Expand Down Expand Up @@ -319,6 +321,12 @@ define([
// tags:
// private
if(this.getParent().isEditing || this.onTouchStart(e) === false){ return; } // user's touchStart action
var enclosingScrollable = viewRegistry.getEnclosingScrollable(this.domNode);
if(enclosingScrollable &&
domClass.contains(enclosingScrollable.containerNode, "mblScrollableScrollTo2")){
// #17165: do not select the item during scroll animation
return;
}
if(!this._onTouchEndHandle && this._selStartMethod === "touch"){
// Connect to the entire window. Otherwise, fail to receive
// events if operation is performed outside this widget.
Expand Down

0 comments on commit 84e9020

Please sign in to comment.