Skip to content

Commit

Permalink
Doc-only update. timezone.js overrides dojo/date/locale format() and …
Browse files Browse the repository at this point in the history
…_getZone() methods, but hide that from the doc parser because it obscures the original definitions of the functions. This module in general needs an overhaul though, to return a module value rather than setting global variables. Refs #13101 !strict.

git-svn-id: http://svn.dojotoolkit.org/src/dojox/trunk@29352 560b804f-0ae3-0310-86f3-f6aa0a117693
  • Loading branch information
wkeese committed Jul 20, 2012
1 parent 063d35d commit 807bf6c
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions date/timezone.js
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,10 @@ define(["dojo", "dojo/date", "dojo/date/locale", "dojo/_base/array", "dojo/_base
}

/*=====
// TODO: none of this is AMD friendly. It's setting global variables in dojox,and not returning anything from the module.
// Plus, the override of dojo/date/locale's format() and _getZone() below. This needs to be refactored.
dojox.date.timezone = function(){
// summary:
// mix-in to dojo.date to provide timezones based on
Expand Down Expand Up @@ -706,4 +710,11 @@ dojox.date.timezone.getAllZones = function(){
}
return oGetZone.call(this, dateObject, getName, options);
};

/*=====
// Hide these enhancements from the doc parser because they obscure the original definition of _getZone() and
// format. TODO: change above overrides to around() advice so that original definitions aren't changed.
_ddl.format = oLocaleFmt;
_ddl._getZone = oGetZone;
=====*/
});

0 comments on commit 807bf6c

Please sign in to comment.