Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d3d11] Add D3D11On12CreateDevice stub #2485

Merged
merged 1 commit into from
Feb 7, 2022
Merged

[d3d11] Add D3D11On12CreateDevice stub #2485

merged 1 commit into from
Feb 7, 2022

Conversation

Saancreed
Copy link
Contributor

"Solves" issues like cursey/reframework-d2d#5 by allowing callers to gracefully handle the failure instead of crashing outright.

@doitsujin
Copy link
Owner

doitsujin commented Feb 6, 2022 •
edited
Loading

Any idea why the msvc build is broken? Would that change with your pending PR?

Looks good otherwise though.

@Saancreed
Copy link
Contributor Author

Any idea why the msvc build is broken? Would that change with your pending PR?

Yup, it's the same issue where meson --internal symbolextractor just fails with no error message whatsoever, which my PR is supposed to work around. Your own branch exhibits the same behavior, and so does vkd3d-proton for the last few days. Still no idea why because I can't repro this on my Windows VM.

@doitsujin doitsujin merged commit b5d7b42 into doitsujin:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saancreed @doitsujin