Remove check for pki log folder #5237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the check to pki logs folder because it is not always present. Tomcat 10.1 [1] has modified the logging system introducing a lazy creation so log folder and file are created only if there is something to write. Therefore, the pki folder for pki webapps logs is not created since at default logging level there should be no logs. 1. https://fedoraproject.org/wiki/Changes/Tomcat10ChangeProposal#Detailed_Description
Member
Author
|
The check was working when fedora move to tomcat 10 because there was a problem generating some logs as visible in the latest green test for the server which print the log in pki folder. The error was generating from the package tomcat-jakartaee-migration which has been updated 2 weeks ago and from few days is distributed. |
|
edewata
approved these changes
Dec 4, 2025
Contributor
edewata
left a comment
edewata
left a comment
There was a problem hiding this comment.
Nice! Thanks for looking into this.
Member
Author
|
@edewata Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the check to pki logs folder because it is not always present.
Tomcat 10.1 [1] has modified the logging system introducing a lazy creation so log folder and file are created only if there is something to write. Therefore, the pki folder for pki webapps logs is not created since at default logging level there should be no logs.