Update pkidestroy to support ACME #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkidestroy has been updated to support removing ACME from PKI server. If it is the last subsystem on the server, the server will be removed as well. The ACMESubsystem.create() has been modified to create a base dir (i.e. /var/lib/pki/<instance>/<subsystem>) which is used by PKIServer.load_subsystems() to determine if the subsystem exists. The code that creates the conf and logs folders has been moved into create_conf() and create_logs(), respectively. The pki-server acme-remove has been updated to provide options to remove the conf and logs folders. The tests that use pkispawn to install ACME have been updated to use pkidestroy to remove ACME.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkidestroyhas been updated to support removing ACME from PKI server. If it is the last subsystem on the server, the server will be removed as well.The
ACMESubsystem.create()has been modified to create a base dir (i.e./var/lib/pki/<instance>/<subsystem>) which is used byPKIServer.load_subsystems()to determine if the subsystem exists. The code that creates the conf and logs folders has been moved into create_conf() and create_logs(), respectively.The
pki-server acme-removehas been updated to provide options to remove the conf and logs folders.The tests that use
pkispawnto install ACME have been updated to usepkidestroyto remove ACME.