Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable plagiarism detection when language is not supported by dolos #5607

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 13, 2024

This pull request disables the detect plagiarism button for languages that aren't supported by dolos:
image

A tooltip with this explanation is shown on the disabled button.
I had to introduce some new disabled button css to be able to support this tooltip.

The dolos languages are now also hardcoded. Making an API call every time for the supported languages seems a bit overkill. But we'll have to maintain this list. @rien I don't know how often these are expected to change?

Closes #5591

@jorg-vr jorg-vr added the bug Something isn't working label Jun 13, 2024
@jorg-vr jorg-vr self-assigned this Jun 13, 2024
@jorg-vr jorg-vr requested a review from bmesuere as a code owner June 13, 2024 08:47
@jorg-vr jorg-vr merged commit 59e11a2 into main Jun 13, 2024
11 of 13 checks passed
@jorg-vr jorg-vr deleted the fix/disable-plgiarism-lang branch June 13, 2024 12:48
@rien
Copy link
Member

rien commented Jun 13, 2024

The list in the issue you are refering to is not complete (for example: R is missing) For a better up-to-date list you can reffer to https://github.com/dodona-edu/dolos/tree/main/parsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable plagiarism detection when programming language is not supported by Dolos
3 participants