Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for build with mock #710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eabdullin1
Copy link

Hello!
During the build of Docker, I encountered the fact that it cannot be built using a mock. Changes in the PR allow you to build not from under the user's root, as well as use a mock.

- Add fedora define

Signed-off-by: eabdullin <[email protected]>
Signed-off-by: eabdullin <[email protected]>
@eabdullin1
Copy link
Author

@rumpl Hello, can you please review this change?

@eabdullin1
Copy link
Author

@thaJeztah Maybe you can help?

@thaJeztah
Copy link
Member

I'm not sure if we should make these changes; all the scripts and specs in this repository are currently designed to be used as part of the Dockerfiles in this repository; IIUC, these changes would mean that the distro-provided golang would be installed (not the version as specified in the GO_IMAGE build-arg.

@eabdullin1
Copy link
Author

Yes, with these changes will be used upstream version of golang from the current distro

@eabdullin1
Copy link
Author

Should we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants