Add hostname check in registry URL on login

docker · May 3, 2024 · e78f0a3 · e78f0a3
1 parent 647ccf3
commit e78f0a3
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/cli/command/registry/login.go b/cli/command/registry/login.go
@@ -4,6 +4,7 @@ import (
  "context"
  "fmt"
  "io"
+ "net/url"
  "strings"
 
  "github.com/docker/cli/cli"
@@ -97,6 +98,16 @@ func verifyloginOptions(dockerCli command.Cli, opts *loginOptions) error {
  opts.password = strings.TrimSuffix(string(contents), "\n")
  opts.password = strings.TrimSuffix(opts.password, "\r")
  }
+
+ if opts.serverAddress != "" {
+ u, err := url.Parse(opts.serverAddress)
+ if err != nil {
+ return errors.Errorf("Invalid server address: %s", opts.serverAddress)
+ }
+ if u.Host == "" {
+ return errors.Errorf("Server address must include a hostname: %s", opts.serverAddress)
+ }
+ }
  return nil
 }