Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(array): allow for type object with DocList #1829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corentinmarek
Copy link

@corentinmarek corentinmarek commented Oct 31, 2023

See issue #1828 for context

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we add a test to show what is exactly what we are aiming to enable or disable?

@JoanFM JoanFM linked an issue Oct 31, 2023 that may be closed by this pull request
6 tasks
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (522811f) 85.05% compared to head (1637c2b) 84.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   85.05%   84.37%   -0.68%     
==========================================
  Files         135      135              
  Lines        9031     9031              
==========================================
- Hits         7681     7620      -61     
- Misses       1350     1411      +61     
Flag Coverage Δ
docarray 84.37% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/array/doc_list/doc_list.py 87.30% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocList raises exception for type object.
2 participants