Add MaximumPageSize const property for limit page size #6034
Conversation
| @@ -37,6 +37,7 @@ public class SearchServiceController : DnnApiController | |||
| private const string ModuleTitleCacheKey = "SearchModuleTabTitle_{0}"; | |||
| private const CacheItemPriority ModuleTitleCachePriority = CacheItemPriority.Normal; | |||
| private const int ModuleTitleCacheTimeOut = 20; | |||
| private const int MaximumPageSize = 100; | |||
There was a problem hiding this comment.
100 seems a little small to me for an absolute limit. If we made this configurable via a host setting, I'm fine with 100 as a default.
There was a problem hiding this comment.
I agree with you but when the user searches in DNN, shows a maximum of 100 results per page.
|
Just to be sure this maximum is only per page right, one could still obtain more results but on other pages correct? |
|
@valadas yes, of course. I just set the maximum page size per page. |
|
Ok, I am not too concerned with this but like Brian said, it would be nicer if that value comes from the web.config or a host setting and could be changed without having to recompile. I could see potential implementations where that API gets called from 3rd party modules that may need more results and not support paging (would only get page 1). |
|
Sounds like a decent place to put that yes. |
|
@valadas Thanks. |
Add MaximumPageSize const property for limit page size
Fixes #6033