Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿค– Refactor(#117): type ์ง€์ • ๋ฐ ๋ถˆํ•„์š”ํ•œ ๋กœ์ง ์ œ๊ฑฐ #118

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

seoyoung81
Copy link
Collaborator

@seoyoung81 seoyoung81 commented Jun 10, 2024

๐Ÿ“PR Description

์ด์Šˆ ๋ฒˆํ˜ธ : #117

๐Ÿ”จ์ž‘์—… ๋‚ด์šฉ

  • ๋ฉ”์ธํŽ˜์ด์ง€ ๋ฐฐ๊ฒฝ ์ด๋ฏธ์ง€, ๊ธ€์ž
  • ์บ๋Ÿฌ์…€ ํƒ€์ž… ์ง€์ • ๋ฐ ๋ฆฌํŒฉํ„ฐ๋ง

๐Ÿ’Ž๊ฒฐ๊ณผ (์‚ฌ์ง„ ๋ฐ ์ž‘์—… ๊ฒฐ๊ณผ)

image

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
dnd-10th-7-frontend โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 18, 2024 1:33pm

Copy link
Member

@chamny20 chamny20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ๊ตฟ ๋ชจ๋‘ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค~
useMemo ์‚ฌ์šฉํ•œ ๊ฒƒ๋„ ์ข‹์Šต๋‹ˆ๋‹ค ์ตœ๊ณ ์ตœ๊ณ !

@@ -11,6 +10,17 @@ import { useGetProjectRecommend } from "@component/hooks/useProject";
import ArrowBackIosNewRoundedIcon from "@mui/icons-material/ArrowBackIosNewRounded";
import ArrowForwardIosRoundedIcon from "@mui/icons-material/ArrowForwardIosRounded";

export interface RecommendData {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: ์ด ๋ถ€๋ถ„์€ types์— ๋”ฐ๋กœ ๋นผ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”!

src/app/page.tsx Outdated
@@ -17,33 +16,54 @@ export default function Home() {
}
}, []);

const [windowWidth, setWindowWidth] = useState(
Copy link
Member

@chamny20 chamny20 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3: ์œˆ๋„์šฐ ๋„ˆ๋น„์ฒดํฌํ•˜๋Š” ์š” ๋ถ€๋ถ„์€ useWindowSize์™€ ๊ฐ™์ด ํ›…์œผ๋กœ ๋นผ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™๋„ค์š”~
๊ทผ๋ฐ ์—ฌ๊ธฐ์„œ๋งŒ ์‚ฌ์šฉ๋  ๊ฒƒ ๊ฐ™๋‹ค๋ฉด ๊ตณ์ด ์•ˆํ•ด๋„ ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹น!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useWindowSize ๊ด€๋ จ ํ›…์œผ๋กœ ๋ถ„๋ฆฌํ•  ์ƒ๊ฐ์„ ๋ชปํ–ˆ๋„ค์š”..! ๐Ÿ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants