Skip to content

Conversation

@vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Apr 4, 2023

Fixes #11495

Status

ready

Description

Provide robust implementation for calculating checksum based on sorted list of groups. Also, account for new groups if they will be added into CRIC system. In other words, new code can handle any set of groups, e.g. group:user or iam_group:test or site:T1_XX_YYYY or their combination or any other group.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

@vkuznet vkuznet self-assigned this Apr 4, 2023
@vkuznet vkuznet added Technical Debt Used to track issues that address technical needs internal to WM team HTTP Auth labels Apr 4, 2023
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 21 new failures
    • 1 tests no longer failing
    • 1 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 8 warnings and errors that must be fixed
    • 41 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 4 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14172/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 21 new failures
    • 1 tests no longer failing
    • 1 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 5 warnings and errors that must be fixed
    • 41 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 4 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14173/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 43 new failures
    • 1 tests no longer failing
    • 1 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 7 warnings and errors that must be fixed
    • 71 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 17 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14174/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auth HTTP Technical Debt Used to track issues that address technical needs internal to WM team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken authentication for users in the REST module upon adding a new type of groups in CRIC

2 participants