Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing abstract methods in SerializedOfflinePlayer #2759

Closed
wants to merge 1 commit into from
Closed

add missing abstract methods in SerializedOfflinePlayer #2759

wants to merge 1 commit into from

Conversation

wuangg
Copy link

@wuangg wuangg commented Jan 24, 2024

Add some missing abstract methods from OfflinePlayer that introduced in recent Spigot 1.20.4 API to SerializedOfflinePlayer to fix a compile error.

Fixes #2758.

derklaro
derklaro approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@derklaro derklaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really make this class abstract and implement all methods that do nothing in runtime using ByteBuddy (or just remove it, if possible, but I guess not)...

@wuangg
Copy link
Author

wuangg commented Feb 1, 2024

Close this in favor of #2777.

@wuangg wuangg closed this Feb 1, 2024
@wuangg wuangg deleted the add-missing-overrides branch February 1, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derklaro derklaro derklaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation Failure: SerializedOfflinePlayer Missing getLocation Override
2 participants
@wuangg @derklaro